On Tue, 2 Jul 2024 01:44:43 GMT, fabioromano1 <d...@openjdk.org> wrote:
>> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The algorithm is proved to be asymptotically faster than the Newton's >> Method, even for small numbers. To get an idea of how much the Newton's >> Method is slow, consult my article >> [here](https://arxiv.org/abs/2406.07751), in which I compare Newton's Method >> with a version of classical square root algorithm that I implemented. After >> implementing Zimmermann's algorithm, it turns out that it is faster than my >> algorithm even for small numbers. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Ensure normalized value in MutableBigInteger initialization with ints These helpful considerations, and others that are not obvious when comparing with the paper, should really be part of comments in the code. As mentioned, this helps with reviewing and for maintenance. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2218338467
