On Thu, 18 Jul 2024 21:32:31 GMT, Chen Liang <[email protected]> wrote:
>> src/java.base/share/classes/java/lang/Process.java line 505:
>>
>>> 503: public boolean waitFor(Duration duration) throws
>>> InterruptedException {
>>> 504: Objects.requireNonNull(duration, "duration");
>>> 505: return waitFor(TimeUnit.NANOSECONDS.convert(duration),
>>> TimeUnit.NANOSECONDS);
>>
>> With this change, the update to ProcessTools is unnecessary and could be
>> backed out.
>
> The `ProcessTools` override is a delegating override; I think it still makes
> sense and should be kept.
I think the test tool should not depend on the internal implementation, so I
think it should be kept.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20220#discussion_r1683545877
