On Wed, 31 Jul 2024 01:46:09 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> First pass at adding some quality of implementation discussions around the >> overridable methods of Object. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - Merge branch 'master' into JDK-8336043 > - Respond to review feedback. > - Merge branch 'master' into JDK-8336043 > - Appease jcheck. > - JDK-8336043: Add quality of implementation discussion to Object.{equals, > toString, hashCode} src/java.base/share/classes/java/lang/Object.java line 125: > 123: * collections}. > 124: * > 125: * As as a quality of implementation concern, a particular "As as" typo. "particular" is unnecessary. "a" -> "an" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20128#discussion_r1705969830