On Tue, 13 Aug 2024 23:41:06 GMT, Rafael Winterhalter
<winterhal...@openjdk.org> wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8337302: Fix copyright years.
test/jdk/java/lang/reflect/Generics/TestMissingTypeVariable.java line 43:
> 41: public class TestMissingTypeVariable {
> 42:
> 43: public static void main(String[] args) throws Exception {
To make the test more understandable to casual readers, I suggest putting the
corresponding source code, as much as possible, as a comment.
test/jdk/java/lang/reflect/Generics/TestMissingTypeVariable.java line 52:
> 50: classBuilder.withField("f",
> 51: ClassDesc.of("java.lang.Object"),
> 52: fieldBuilder ->
> fieldBuilder.withFlags(AccessFlag.PUBLIC).with(SignatureAttribute.of(Signature.parseFrom("TA;"))));
If the signature is incorrect, please leave a comment describing how it is
incorrect. "// Type A is non-existent" etc.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20535#discussion_r1719247725
PR Review Comment: https://git.openjdk.org/jdk/pull/20535#discussion_r1719248512
