On Wed, 14 Aug 2024 15:55:53 GMT, Severin Gehwolf <[email protected]> wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Testcase update upon review by Severin Gehwolf
>
> test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 139:
>
>> 137: } else {
>> 138: throw new IllegalArgumentException();
>> 139: }
>
> This can be done once in `NestedCgroup.main` and then passed in on
> instantiation of `Test*` classes.
It cannot because jdk.internal.platform.Metrics is JDK-private and it must be
exported by jtreg `@modules java.base/jdk.internal.platform`. And this jtreg
export does not work for the newly spawned Java as I cannot replicate the jtreg
commandline, I haven't found it in system properties.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17198#discussion_r1720605769
