On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated CSR on trivial >> removal of `abstract` modifier as well. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Redundant transient; Update the comments to be more accurate Catching up on reviews, core libs changes look fine. Since Executable is sealed with Constructor and Executable on its permits lists, moving methods up and down the hierarchy (as long as there are concrete methods on Constructor and Method) is fine. ------------- Marked as reviewed by darcy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20188#pullrequestreview-2246761996
