On Mon, 2 Sep 2024 15:27:59 GMT, Shaojin Wen <[email protected]> wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> typo
src/java.base/share/classes/java/lang/StringCoding.java line 39:
> 37: class StringCoding {
> 38: private static final Unsafe UNSAFE = Unsafe.getUnsafe();
> 39: private static final long POSITIVE_MASK =
> 0b1000000_1000000_1000000_1000000_1000000_1000000_1000000_1000000L;
Shouldn't this be
`0b10000000_10000000_10000000_10000000_10000000_10000000_10000000_10000000L`?
Either way this new method needs a sanity test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20772#discussion_r1741141281
