On Thu, 5 Sep 2024 13:22:53 GMT, Claes Redestad <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/RawBytecodeHelper.java
>> line 235:
>>
>>> 233: * we have a valid opcode.
>>> 234: */
>>> 235: public boolean next() {
>>
>> In C1, this cannot be inlined. See if you need to add ForceInline
>
> I don't think we should worry too much about making C1 inline more
> aggressively.
C2 needs 10000 calls to inline this method, so wenshao is worried. However,
this method call is almost always followed by a huge switch to handle different
opcode, so I doubt how much of a difference inlining brings.
But wenshao discovered that this method has too many field gets; I should
indeed convert them to local variable access if possible.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20863#discussion_r1745548698
