On Wed, 11 Sep 2024 02:28:45 GMT, David Holmes <dhol...@openjdk.org> wrote:
> With regards to the nsk tests, are `beforeSleep` and `afterSleep` still > potential candidates now that it is impossible for them to throw OOME? These tests are sampling and checking for specific methods and call stacks, I don't think they are provoke OOME. So the changes just are cleanup as these it won't sample frames with these methods with the code change. I don't think ThreadSleepEvent.<clinit> will be sampled now but maybe ThreadSleepEvent.<init> will. These tests are crying out to be replaced as they make too hard to do changes in this area. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20923#issuecomment-2342693403
