On Mon, 23 Sep 2024 13:54:52 GMT, Per Minborg <[email protected]> wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add to specification and refine detection of PL GLs
src/java.base/share/classes/java/lang/foreign/Linker.java line 265:
> 263: * its non-padding layout elements, or to satisfy (2), and</li>
> 264: * <li>{@code G} is {@code G.memberLayouts().isEmpty()} or (at the same
> time) not all
> 265: * elements are padding layouts.</li>
I suggest splitting the last list item into 2. The prior item also needs to be
cleaned up (replace `, and` with `;`).
Not sure what you mean here with 'at the same time'? An empty group layout can
not contain padding layouts.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21041#discussion_r1771590123
