On Thu, 26 Sep 2024 00:05:13 GMT, Chen Liang <li...@openjdk.org> wrote:

>> This PR split out large array/set construction into separate factory methods 
>> to avoid oversized method trying to construct several of those.
>> 
>> In order to do that, we will need to generate those help methods on demand 
>> in the class builder. Here we have two approach, one is for dedup set, which 
>> is processed in advance so we can know what methods should be created.
>> 
>> Another is for random set, such as packages, thus we put those request into 
>> a queue to amend the class later.
>> 
>> To keep the optimization of caching built value that are references more 
>> than once, it was implemented using local vars, which doesn't work well for 
>> helper methods. The existing approach to populate local vars doesn't work 
>> well with larger scope of split operation, as the slot was allocated on 
>> lazily built, but the transfer is captured in advance, this count could 
>> mismatch as built time and run time.
>> 
>> So we make this build in advance, and use a static array for values referred 
>> more than once.
>> 
>> All the codegen instead of giving index to be loaded, the builder snippet 
>> now load the wanted set/array to the operand stack to be consistent.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>  line 1248:
> 
>> 1246:                             methodName,
>> 1247:                             MethodTypeDesc.of(CD_EXPORTS.arrayType()),
>> 1248:                             ACC_PRIVATE | ACC_FINAL | ACC_STATIC,
> 
> Just curious, why do we mark our split provider methods final? The final flag 
> is only used for hiding.

Thanks for pointing that out, I just follow language convention and did not 
think of that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1776178931

Reply via email to