On Sat, 28 Sep 2024 13:53:03 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Updated. > > Hello Henry, I think this `-k` option help text would need a slight > modification. Right now it states that if a file appears more than once in an > archive, then this setting this flag will not overwrite the earlier copies. > In reality, it doesn't matter how many times the file appears in the archive > - even if it appears just once, and if the file is being extracted into a > directory which already has the same named file at that path, then this `-k` > flag will not overwrite that existing file. > > So I think we should reword it to talk about its behaviour in context of some > file already existing in the destination directory where the jar contents are > being extracted. > > I wonder if we should make a mention that we don't do any case sensitive > checks for the existence of the file in the destination directory and instead > we use filesystem API to check for existence (which depending on the > filesystem may be case insensitive, like macosx). You have valid point. I refer to the tar man page, and I thought do not overwrite existing files says it. The in particular is just to call out a specific use case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21141#discussion_r1781344445
