On Thu, 19 Sep 2024 22:12:58 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Change "found" to "should be" in the error messages >> - Merge remote-tracking branch 'upstream/master' into >> source-based-since-checker >> - avoid using `continue`, fix mistake in last commit >> - extend SinceChecker to now skip some packages >> - Merge remote-tracking branch 'upstream/master' into >> source-based-since-checker >> - Merge remote-tracking branch 'upstream/master' into >> source-based-since-checker >> - Merge remote-tracking branch 'upstream/master' into >> source-based-since-checker >> - Skip over files and packages that aren't found >> - Move the tests to module/module_name directory for clearer naming >> - (C) >> - ... and 18 more: https://git.openjdk.org/jdk/compare/bc36ace7...d355222e > > test/jdk/tools/sincechecker/SinceChecker.java line 152: > >> 150: String version = String.valueOf(i); >> 151: Elements elements = ct.getElements(); >> 152: elements.getModuleElement("java.base"); // forces module >> graph to be instantiated > > @lahodaj I've always considered this kind of line to be a workaround; it > would be nice if we could have an RFE so this kind of line was unnecessary in > code that wants to introspect the elements Thanks. I've filled: https://bugs.openjdk.org/browse/JDK-8341342 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18934#discussion_r1782887236
