On Mon, 7 Oct 2024 06:46:23 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update module-info of java.scripting to note about jrunscript tool
>> deprecation
>
> src/java.scripting/share/classes/module-info.java line 31:
>
>> 29: * <p> The <em>{@index jrunscript jrunscript tool}</em> included in the
>> JDK
>> 30: * implementation of this module, has been deprecated for removal since
>> 31: * JDK 24 and will be removed in a future release.
>
> I think it would be better to keep the original text and just add new a
> sentence to say that the tool has been deprecated for removal in a future
> release.
Done, I've now updated the PR to retain the old text, plus add a new line
noting about the deprecation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21380#discussion_r1789627816