On Wed, 9 Oct 2024 21:11:16 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> @rgiulietti At least for me, the expression "the bits that differ from its >> sign bit" is misleading, it seems to implicitly imply that he is talking >> about the 1s bits which are not sign bits, while it means the bits whose >> value differs from the value of the sign bits... > > The class Javadoc mentions, in at least two places, that the two's complement > representation conceptually has an infinite number of leading virtual sign > bits. > Once this point is clear, IMO the method's own Javadoc is then clear in turn. > Maybe it could be improved as in "the bits that differ _in value_ from its > sign bit". (Changing the spec requires another process and another, separate > issue, but it can be done if needed.) @rgiulietti So it must have been my limitation, but I didn't realize it, even though I knew that there are virtually infinite sign bits... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21323#discussion_r1794847956
