On Tue, 15 Oct 2024 20:45:46 GMT, Alex Menkov <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disallow NotifyFramePop for
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 703:
>
>> 701: if (java_lang_VirtualThread::is_instance(vthread)) { // paranoid
>> check for safety
>> 702: if (java_lang_Thread::is_in_VTMS_transition(vthread)) {
>> 703: jvf =
>> check_and_skip_hidden_frames(java_lang_Thread::is_in_VTMS_transition(vthread),
>> jvf);
>
> it's just checked that `java_lang_Thread::is_in_VTMS_transition(vthread)` is
> true
> Suggestion:
>
> jvf = check_and_skip_hidden_frames(true, jvf);
Good catch, thanks. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1802057401
