On Fri, 18 Oct 2024 20:29:00 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change field -> fields
>
> test/jdk/java/util/zip/ZipEntry/MaxZipEntryFieldSizeTest.java line 28:
>
>> 26: * @summary Verify that ZipEntry(String), ZipEntry::setComment, and
>> 27: * ZipEntry::setExtra throws a IllegalArgumentException when the
>> 28: * combined length of the fields, including the size of the CEN Header,
>
> A test where the combined length exceeds the limit, but no one field alone
> exceeds the limit would be a nice addition.
I am going to leat the comment as is
> test/jdk/java/util/zip/ZipEntry/MaxZipEntryFieldSizeTest.java line 60:
>
>> 58: static final short UNKNOWN_ZIP_TAG = (short) 0x9902;
>> 59: // ZIP file to be used by the tests
>> 60: static final Path ZIP_FILE = Path.of("ZipEntryFieldSize.zip");
>
> Seems unused?
Yes a holdover from the original version removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21544#discussion_r1806995772
PR Review Comment: https://git.openjdk.org/jdk/pull/21544#discussion_r1806996024
