On Fri, 18 Oct 2024 21:43:49 GMT, Naoto Sato <[email protected]> wrote:
>> Changing the charset initialization of `java.io.Console` class, which is the
>> basis of `java.io.IO`, so that it would behave the same way as `System.out`
>> wrt encoding. This change will also have the capability to override the
>> default charset used in `IO` methods with `stdout.encoding` system property.
>> A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Explicitly refer to `stdout.encoding`
src/java.base/share/classes/java/io/Console.java line 584:
> 582: * The returned charset corresponds to the input and output source
> 583: * (e.g., keyboard and/or display) specified by the host environment
> or user,
> 584: * which defaults to the one based on {@link System##stdout.encoding
> stdtout.encoding}.
In System.getProperties, this is specified for as the encoding for System.out.
That may need to be expanded to say Console too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21569#discussion_r1807215667
