On Tue, 22 Oct 2024 16:22:26 GMT, Brian Burkhalter <[email protected]> wrote:
> I assume you'll run the test many tests on all platforms to ensure its
> stability before integrating.
I ran the version of commit f4ab451 30 times on all platforms without failures.
>> test/jdk/java/nio/file/Files/InputStreamTest.java line 29:
>>
>>> 27: * @library .. /test/lib
>>> 28: * @build jdk.test.lib.Platform
>>> 29: * @run junit InputStreamTest
>>
>> I think this will need --enable-native-access=ALL-UNNAMED.
>
> It works as is in the CI.
Changed in f4ab451.
>> test/jdk/java/nio/file/Files/InputStreamTest.java line 99:
>>
>>> 97: try {
>>> 98: try (FileOutputStream fos = new
>>> FileOutputStream(PIPE);)
>>> 99: {
>>
>> The formatting is a bit messed up, I think a previous iteration has a second
>> resource that is now removed.
>
> Thanks, I'll clean it up.
Cleaned up in f4ab451.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21508#issuecomment-2430365919
PR Review Comment: https://git.openjdk.org/jdk/pull/21508#discussion_r1811476591
PR Review Comment: https://git.openjdk.org/jdk/pull/21508#discussion_r1811476822
