On Wed, 23 Oct 2024 04:20:49 GMT, Chen Liang <li...@openjdk.org> wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses >> `componentType` and `arrayType` for `aaload` `aastore` instructions, which >> are currently quite slow. We can split out array class descriptors from >> class or interfaces to support faster `arrayType` and `componentType` >> operations. >> >> Tentative, as I currently have no way to measure the actual impact of this >> patch on the startup performance; however, this made the `ClassDesc` >> implementations much cleaner. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 19 commits: > > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/array-cd > - Restore the impl spec to the API spec > - Relax displayName spec > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/array-cd > - Merge > - object array desc constant > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/array-cd > - Mandy reviews > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/array-cd > - mlchung suggestions: elementType, improve utility methods > - ... and 9 more: https://git.openjdk.org/jdk/compare/d6eddcda...bf9ff94c Just noticed that the `ArrayClassDesc::displayName` was buggy - existing tests had no coverage and I have added test coverage for `displayName` and a few other missed methods. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20665#issuecomment-2430998033