On Wed, 30 Oct 2024 01:49:48 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's review - fix code comment about Microsoft C Runtime Library > > src/java.base/windows/native/libjli/java_md.c line 360: > >> 358: /* >> 359: * The Microsoft C Runtime Library needs to be loaded first. A copy >> is >> 360: * assumed to be present within the JDK. If it is not found there > > I decided not to explicitly mention the "bin" directory here and let that be > explained in the implementation of the `LoadMSVCRT()` function itself. If you > think we should include the "bin" part here too, then let me know. That's okay, main thing is that the comment that said it was in the root directory has been fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21704#discussion_r1822012759
