On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda <[email protected]> wrote:
>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`,
>> with the (hopefully) obvious semantics, plus the corresponding wiring to
>> make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing test for Console.readln/readLine, ensuring the proper methods are
> called.
src/java.base/share/classes/java/io/Console.java line 240:
> 238: * if an end of stream has been reached without having read
> 239: * any characters.
> 240: *
Should we specify (both here and in the `IO.readln()`) what is returned if only
the line-terminator character is read from the console? A brief look at the
implementation seems to suggest that we return an empty `String`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21693#discussion_r1822111523
