On Wed, 30 Oct 2024 18:34:49 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update from comments and add benchmark > > src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java > line 546: > >> 544: } >> 545: final UnmapperProxy unmapper = NIO_ACCESS.unmapper(b); >> 546: return unmapper == null > > I would feel more at ease if the creation of segments went through > SegmentFactories (this is not a new issue in this PR) https://bugs.openjdk.org/browse/JDK-8343347 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21764#discussion_r1824104624
