On Thu, 31 Oct 2024 02:26:42 GMT, David Holmes <[email protected]> wrote:
>> src/hotspot/share/runtime/objectMonitor.inline.hpp line 207:
>>
>>> 205: }
>>> 206:
>>> 207: inline bool ObjectMonitor::has_successor() {
>>
>> Why are _succ accesses atomic here when previously they were not?
>
> General convention is that racily accessed variables should be accessed via
> Atomic::load/store to make it clear(er) they are racy accesses. But I agree
> it seems odd when direct accesses to `_succ` in the main cpp file are not
> atomic.
> Why are _succ accesses atomic here when previously they were not?
>
They should had always been atomic.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1824794270
