On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. Data changes look to be CLDR 46. Went through the tests as well. Change in build to add the aliases of the preferred value for a deprecated zone LGTM. Left minor comments. make/jdk/src/classes/build/tools/cldrconverter/TimeZoneParseHandler.java line 30: > 28: import java.io.File; > 29: import java.io.IOException; > 30: import java.util.Map; nit: not sure we need this since we declared `map` as var. test/jdk/java/text/Format/DateFormat/TimeZoneNameTest.java line 27: > 25: * @test > 26: * @bug 4348864 4112924 4425386 4495052 4836940 4851113 8008577 8174269 > 27: * 8333582 Should this be included if there are no changes to the file (or other related files)? ------------- Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/21772#pullrequestreview-2408683088 PR Review Comment: https://git.openjdk.org/jdk/pull/21772#discussion_r1825012939 PR Review Comment: https://git.openjdk.org/jdk/pull/21772#discussion_r1824914061
