On Wed, 30 Oct 2024 14:27:03 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which cleans up a leftover code from > the launcher's java_md_macosx.m file? > > In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the > launcher code to remove checks for `<apphome>/jre/lib/` when determining the > JDK installation root. Those changes were done in the Unix and Windows files > and the macosx one got left out, likely due to an oversight. > > The commit in this PR removes that leftover code. No new tests have been > added and existing tier1, tier2, tier3 tests continue to pass. src/java.base/macosx/native/libjli/java_md_macosx.m line 432: > 430: } > 431: } > 432: /* ensure storage for path + /jre + NULL */ The corresponding changes in JDK-8329862 included adding a call to JLI_TraceLauncher. Such as: ` JLI_TraceLauncher("Attempt to get JDK installation root from launcher executable path\n"); ` Adding a similar trace message would be consistent across platforms. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21789#discussion_r1825895271
