On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy <[email protected]> wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
431:
> 429: * @see java.lang.Float#valueOf(String)
> 430: */
> 431: public static Float16 valueOf(String s) throws NumberFormatException
> {
The current implementation throws when the input is `"NaN"`, with or without an
optional sign.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1836721773
