On Tue, 12 Nov 2024 15:09:23 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), > Serialization implementation dependencies on SecurityManager, doPrivildged, > and AccessController are removed. > Some refactoring to cleanup the remaining code is expected. src/java.base/share/classes/java/io/ObjectInputStream.java line 1551: > 1549: * is "safe", FALSE otherwise. > 1550: */ > 1551: @SuppressWarnings("removal") Can the `@SuppressWarnings` be removed? src/java.base/share/classes/java/io/ObjectInputStream.java line 2651: > 2649: > 2650: Callback(ObjectInputValidation obj, int priority, Callback > next) > 2651: { I assume the "{" can move back to the previous line now. src/java.base/share/classes/java/io/ObjectStreamClass.java line 279: > 277: * @return the {@code Class} instance that this descriptor > represents > 278: */ > 279: @CallerSensitive I assume this is no longer caller-sensitive. src/java.base/share/classes/java/io/ObjectStreamClass.java line 918: > 916: if (cons != null) { > 917: try { > 918: return cons.newInstance(); Do the ObjectStreamClass.newInstance still need suppress-warnings? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22041#discussion_r1838462339 PR Review Comment: https://git.openjdk.org/jdk/pull/22041#discussion_r1838463499 PR Review Comment: https://git.openjdk.org/jdk/pull/22041#discussion_r1838465737 PR Review Comment: https://git.openjdk.org/jdk/pull/22041#discussion_r1838468010
