On Fri, 8 Nov 2024 23:57:58 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> The PR affects jpackage test library only. Changes: > > - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is > still used as there is no better alternative. > - Use `TKit.concatMessages()` instead of `String.format()` in > TKit.assert...() methods. > - Added unit tests for all TKit.assert...() modified methods. > - Added unit tests for `JavaAppDesc` class. > - Added `jdk.jpackage.test.TestSuite` class to automatically run all jpackage > test library unit tests. This eliminates the need to add jtreg comments to > every jpackage test library unit test java source. Looks good with minor comment. test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/TKitTest.java line 146: > 144: }).toArray(String[]::new); > 145: } > 146: return new MethodCallConfig(method, args, expectFail, > effectiveExpectLog); Extra space between `expectFail, effectiveExpectLog`. ------------- PR Review: https://git.openjdk.org/jdk/pull/21995#pullrequestreview-2430900228 PR Review Comment: https://git.openjdk.org/jdk/pull/21995#discussion_r1838899686
