On Wed, 13 Nov 2024 10:57:10 GMT, Jaikiran Pai <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert unnecessary copyright change in ProcessEnvironment.java.
>> Fix code style in ProcessImpl
>> Drop unneeded suppress warnings.
>> Remove obsolete @throws SecurityExceptions
>
> src/java.base/windows/classes/java/lang/ProcessImpl.java line 516:
>
>> 514: }
>> 515:
>> 516: return null;
>
> I think this is an oversight - returning `null` from the constructor would be
> an compile error.
Actually, looking at the GitHub actions job, it appears to have caught one
other compilation error in this file:
jdk\jdk\src\java.base\windows\classes\java\lang\ProcessImpl.java:423: error:
';' expected
final String value =
System.getProperty("jdk.lang.Process.allowAmbiguousCommands", "true"));
^
1 error
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22024#discussion_r1839992366
