On Wed, 13 Nov 2024 14:12:34 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), >> Serialization implementation dependencies on doPriviledged and >> AccessController are removed. >> Some refactoring to cleanup the remaining code is expected. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unnecessary suppress warnings removal > ServiceLoader configuration exceptions (in a static initialization) are > rethrown as Error. > Remove dependency on SecurityException thrown by ServiceLoader (as obsolete) src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java line 1: > 1: /* Lines 171-172: if (ex.getCause() instanceof SecurityException) { continue; // ignore the security exception, try the next provider } You may be able to remove this code, but may be better to leave it as-is for now until the SL code has been checked for cleanup. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22042#discussion_r1840369340
