On Thu, 14 Nov 2024 17:01:48 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Please review this PR which cleans up SecurityManager-related code following
>> JEP-486 integraion.
>>
>> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
>> * `ZipFileSystemProvider` is updated to not perform
>> `AccessController::doPrivileged`
>> * The test `TestPosix` is updated to perform `AccessController.doPrivileged`
>>
>> This change should be relatively straight-forward to review. Reviewers may
>> want to look extra close at the exception-unwrapping code in
>> `ZipFileSystem::initOwner` and `ZipFileSystem::initGroup`.
>>
>> Testing: Tests in `test/jdk/jdk/nio/zipfs` run green locally.
>
> Eirik Bjørsnøs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Revert catching of NoSuchFileException in expectedDefaultOwner and
> expectedDefaultGroup
> - Remove @SuppressWarnings("removal")
Marked as reviewed by mullan (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/22101#pullrequestreview-2437010891
