On Fri, 15 Nov 2024 15:05:41 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final >> >> # Conflicts: >> # src/java.base/share/classes/java/lang/classfile/CustomAttribute.java >> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final >> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final >> >> # Conflicts: >> # src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java >> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final >> >> # Conflicts: >> # src/java.base/share/classes/java/lang/classfile/AccessFlags.java >> # src/java.base/share/classes/java/lang/classfile/ClassBuilder.java >> # src/java.base/share/classes/java/lang/classfile/ClassElement.java >> # src/java.base/share/classes/java/lang/classfile/ClassFileTransform.java >> # >> src/java.base/share/classes/java/lang/classfile/ClassHierarchyResolver.java >> # src/java.base/share/classes/java/lang/classfile/ClassModel.java >> # src/java.base/share/classes/java/lang/classfile/ClassReader.java >> # src/java.base/share/classes/java/lang/classfile/ClassSignature.java >> # src/java.base/share/classes/java/lang/classfile/CodeBuilder.java >> # src/java.base/share/classes/java/lang/classfile/CodeElement.java >> # src/java.base/share/classes/java/lang/classfile/CodeModel.java >> # src/java.base/share/classes/java/lang/classfile/CompoundElement.java >> # src/java.base/share/classes/java/lang/classfile/FieldBuilder.java >> # src/java.base/share/classes/java/lang/classfile/FieldElement.java >> # src/java.base/share/classes/java/lang/classfile/Instruction.java >> # src/java.base/share/classes/java/lang/classfile/MethodBuilder.java >> # src/java.base/share/classes/java/lang/classfile/MethodElement.java >> # src/java.base/share/classes/java/lang/classfile/TypeKind.java >> # >> src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTableAttribute.java >> # >> src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTypeTableAttribute.java >> # >> src/java.base/share/classes/java/lang/classfile/attribute/RuntimeInvisibleAnnotationsAttribute.java >> # >> src/java.base/share/classes/java/lang/classfile/attribute/RuntimeVisibleAnnotationsAttribute.java >> # >> src/java.base/share/classes/java/lang/classfile/constantpool/AnnotationConstantValueEntry.java >> #... > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 78: > >> 76: STRUCTURED_CONCURRENCY, >> 77: @JEP(number=466, title="ClassFile API", status="Second Preview") >> 78: CLASSFILE_API, > > Just remembered that we have to keep this until JDK 24 is the minimum boot > JDK; with this removed bootcycle build should fail. Oops. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19826#discussion_r1844042001
