On Fri, 15 Nov 2024 17:49:58 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains four commits: > > - Merge branch 'master' of https://github.com/openjdk/jdk into > docs/cf-instruction > - Typos, long lines > - Labels > - Wip instr Marked as reviewed by darcy (Reviewer). src/java.base/share/classes/java/lang/classfile/Opcode.java line 136: > 134: > 135: /** > 136: * Push {@link TypeKind#FLOAT float} constant {@code 0}. For the float and double constants, it would be a small improvement to write them out as floating-point literals, "0.0f" for a float zero, etc. ------------- PR Review: https://git.openjdk.org/jdk/pull/21625#pullrequestreview-2439472963 PR Review Comment: https://git.openjdk.org/jdk/pull/21625#discussion_r1844372129
