On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian <bchri...@openjdk.org> wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the > java.prefs module. src/java.prefs/share/classes/java/util/prefs/Preferences.java line 248: > 246: } > 247: } > 248: return factory1(); No need to make factory1 a separate method, merge into factory. src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 766: > 764: > 765: protected void syncSpi() throws BackingStoreException { > 766: syncSpiPrivileged(); Inline syncSpiPrivileged(), it doesn't need to be separate and the name "privileged" is misleading ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1848958580 PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1848966359