On Tue, 19 Nov 2024 19:53:45 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc >> linked list with segmented list of arrays. Arrays are easy targets for GC. >> There are possible improvements here, most glaring is parallelism that is >> currently knee-capped by global synchronization. The synchronization scheme >> follows what we have in original code, and I think it is safer to continue >> with it right now. >> >> I'll put performance data in a separate comment. >> >> Additional testing: >> - [x] Original reproducer improves drastically >> - [x] New microbenchmark shows no regression on "churning" tests, which >> covers insertion/removal perf >> - [x] New microbenchmark shows improvement on Full GC times (crude, but >> repeatable), serves as a proxy for reproducer >> - [x] `java/lang/ref` tests in release >> - [x] `all` tests in fastdebug > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Use RandomFactory in test Changes requested by bchristi (Reviewer). test/jdk/jdk/internal/ref/Cleaner/CleanableListTest.java line 126: > 124: bs.set(idx, true); > 125: } > 126: } Can the test remove everything left in the list after doing the `RANDOM_ITERATIONS`? ------------- PR Review: https://git.openjdk.org/jdk/pull/22043#pullrequestreview-2447166752 PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1849383928
