On Fri, 22 Nov 2024 23:05:11 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> Cleanup of doPrivileged in:
> sun.util.calendar
> sun.util.local/provider
> sun.util.cldr
> sun.util.resources
Thanks for the fix in this area. Looks good with a couple of minor nit
src/java.base/share/classes/sun/util/resources/BreakIteratorResourceBundle.java
line 72:
> 70: + '/' + info.getString(key);
> 71: byte[] data;
> 72: try (InputStream is =
> getClass().getModule().getResourceAsStream(path);) {
`;` is not needed
src/java.base/share/classes/sun/util/resources/Bundles.java line 268:
> 266: return bundle;
> 267: }
> 268: } catch (ServiceConfigurationError | SecurityException e) {
`SecurityException` can be removed
-------------
PR Review: https://git.openjdk.org/jdk/pull/22336#pullrequestreview-2456033295
PR Review Comment: https://git.openjdk.org/jdk/pull/22336#discussion_r1854914652
PR Review Comment: https://git.openjdk.org/jdk/pull/22336#discussion_r1854916974
