On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing changes src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java line 87: > 85: @SuppressWarnings("restricted") > 86: private static void loadPrefsLib() { > 87: System.loadLibrary("prefs"); What am I missing? Why keep the private static method if it only contains a single method invocation and is only used in the static initializer? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1857215881