On Thu, 28 Nov 2024 16:30:36 GMT, Alan Bateman <[email protected]> wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove com.sun.jndi.ldap.VersionHelper
>
> src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java
> line 70:
>
>> 68: null,
>> 69: new RuntimePermission("ldapDnsProvider"),
>> 70: SecurityConstants.GET_CLASSLOADER_PERMISSION);
>
> Can you check if SecurityConstants.GET_CLASSLOADER_PERMISSION be removed now,
> I think this is the last usage.
I'm thinking we could simply remove SecurityConstants when nothing references
it anymore - and not bother with removing its fields in the meantime. Would you
advise removing its other possibly unused fields?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22421#discussion_r1862476528
