On Tue, 3 Dec 2024 14:28:22 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 131:
>>
>>> 129: // Default branding.conf value is "N/A", which did not affect
>>> java.vm.vendor
>>> 130: if (! VENDOR_VM.equals("N/A")) {
>>> 131: props.put("java.vm.vendor", VENDOR_VM);
>>
>> Magnus might have suggestions on this, maybe it would be better to default
>> in the conf file to the empty string so that we don't have to deal with
>> "N/A" in several places.
>
> We can surely change the default. We just must make sure that all code that
> uses the vendor define is prepared to handle an empty string.
I think the issue is not the default value, but the special treatment with
default value. Is there a reason we didn't set COMPANY_NAME to "N/A" as in
branding.conf?
https://github.com/openjdk/jdk/blame/master/make/autoconf/spec.gmk.template#L276-L285
Instead of default to "N/A", personally I think "OpenJDK" as an organization
can be used?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1868041678
