Re: RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v3]

[Henry Jen]

On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen <henry...@openjdk.org> wrote:

>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor 
>> and java.vendor.url.
>> 
>> The jlink plugin will change the value in java.lang.VersionProps, which will 
>> set those property values. The `java.vm.vendor` was initialized by VM with 
>> value set at build time, and then later be replaced with value from 
>> VersionProps.
>> 
>> To keep current behavior, we treat 'N/A' value as no-op to mimic current 
>> build behavior. Perhaps we don't really need this, as proper value should be 
>> set with `branding.conf` in official build.
>
> Henry Jen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Set java.vm.vendor from VersionProps.java

src/java.base/share/classes/java/lang/VersionProps.java.template line 97:

> 95:         "@@VENDOR_URL_VM_BUG@@";
> 96: 
> 97:     @SuppressWarnings("unused")

This is no longer needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1868744023