On Wed, 4 Dec 2024 17:52:59 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> - Add missing resource keys to Windows property files;
>>  - Fix the code to throw `ConfigException` if the service installer 
>> executable is required but not available instead of throwing the exception 
>> only when it is not found in the resource directory;
>>  - Fix `JPackageStringBundle.getFormattedString()` that should not use a 
>> resource property string as a format for `MessageFormat.format()` if there 
>> are no arguments for formatting. `MessageFormat.format()` interprets 
>> characters in the format string, e.g., it removes single quotes.
>>  - Add tests.
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Rollback redundant l10n changes

Thanks. Those resource file changes look good to me.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22533#pullrequestreview-2479502843

Reply via email to