On Wed, 4 Dec 2024 19:48:03 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make thread group fields final. > > src/java.rmi/share/classes/sun/rmi/runtime/RuntimeUtil.java line 60: > >> 58: * Cached reference to the system (root) thread group. >> 59: */ >> 60: static final ThreadGroup systemThreadGroup; > > Can this be private? Also userThreadGroup below? Good point. They weren't private in the original, which I just copied over, but I guess we're being a bit more meticulous about making things private these days. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22557#discussion_r1870368408