On Mon, 9 Dec 2024 08:58:19 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>>> Seems like we could simply use
>>> `Boolean.getBoolean("resource.bundle.debug")` instead?
>>
>> Naoto may know the history on this property. It may have been introduced for
>> debugging when working on the RB implementation or maybe it was introduced
>> to allow developers to debug, not sure. If the latter then it's important to
>> preserve long standing behavior. If the former, and it was never documented,
>> there is a lot more flexibility to change.
>
>> If the former, and it was never documented, there is a lot more flexibility
>> to change.
>
> Fair enough. However, this SM change seems to accidentally have introduced a
> bug where the system property is read twice, first calling System.getProperty
> to look up the name of the system property which is then looked up by
> Boolean.getBoolean. That behavior just seems broken.
>
> @RogerRiggs may have intended to use `Boolean::parseBoolean` instead:
>
> `Boolean.parseBoolean(System.getProperty("resource.bundle.debug", "false"))`
>
> which is equivalent to:
>
> `Boolean.getBoolean("resource.bundle.debug")`
Filed https://bugs.openjdk.org/browse/JDK-8345818.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1876255089
