On Thu, 19 Dec 2024 16:27:30 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> We need to raise the abstraction of the SetupBuildLauncher API, to prepare > for static launchers. We should specify the desired outcome, not what flags > we should add. This can be seen as the last part of > [JDK-8141444](https://bugs.openjdk.org/browse/JDK-8141444) (9 years later). > > In the process, I am removing EXTRA_JAVA_ARGS which has not been used for a > long time. I also removed this part from the launcher itself. I'm not convinced this level of abstraction makes things better. It adds quite a bit of overhead for adding additional customization options for when adding new launchers. Could you elaborate more on why this is needed? make/common/modules/LauncherCommon.gmk line 162: > 160: -framework ApplicationServices \ > 161: -framework Cocoa \ > 162: -framework Security, \ What happened to all of these? Were they never needed? ------------- PR Review: https://git.openjdk.org/jdk/pull/22832#pullrequestreview-2516304227 PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1893193068
