On Fri, 20 Dec 2024 12:18:46 GMT, Christian Stein <cst...@openjdk.org> wrote:
>> test/jdk/tools/jar/ReleaseBeforeFiles.java line 26: >> >>> 24: /* >>> 25: * @test >>> 26: * @bug 8167237 8316804 >> >> Have you looked at multiRelease/Basic.java, that might be a better place for >> this. > > Yes, looked at it and thought the this test's name fits better: it's about > checking that `--release` appears before any `FILES` argument. Not? We missing tests to properly exercise this combination of options with MR JARs. I pointed to multiRelease/Basic.java because it tests --describe-module with MR JARs. I think we need to add more tests there to ensure that it prints the correct description when a MR JAR has a module-info.class in a versioned section, or the module-info.class in a version section overrides the module-info.class in the base section. It might be we need further tests to checking ordering of options but we appear to missing some basic tests too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22079#discussion_r1893897468
