On Fri, 20 Dec 2024 14:15:14 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review for this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8302293? >> >> As noted in the issue, when creating a temporary file during the "jar >> --create" operation, if the original file name is lesser than 3 characters, >> the temporary file creation which uses the original file's name as the >> temporary file name prefix, runs into an exception. The commit in this PR >> addresses that issue by ensuring that the temporary file name prefix is >> atleast 3 characters in length. Within the same file, an additional place >> was spotted where the code could potentially run into the same exception, so >> that too has been addressed in this change. >> >> A new jtreg test has been introduced which reproduces the issue and verifies >> the fix. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > simplify assertion in test method Marked as reviewed by lancea (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/22841#pullrequestreview-2517649962
