On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Windows for now until the cause is fully understood.
>
>
> [2025-01-28T16:57:35,721Z]
> c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(94):
> error C2054: expected '(' to follow 'DEF_STATIC_JNI_OnLoad'
> [2025-01-28T16:57:35,721Z]
> c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(94):
> error C2085: 'ZFILE_Open': not in formal parameter list
> [2025-01-28T16:57:35,737Z]
> c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(94):
> error C2143: syntax error: missing ';' before '{'
> [2025-01-28T16:57:35,737Z]
> c:\sb\prod\1738083154\workspace\open\src\java.base\share\native\libzip\zip_util.c(776):
> warning C4013: 'ZFILE_Open' undefined; assuming extern returning int
Marked as reviewed by asemenyuk (Reviewer).
I believe it complained about the way DEF_STATIC_JNI_OnLoad is defined. That is
why disabling the usage of DEF_STATIC_JNI_OnLoad fixes the problem.
-------------
PR Review: https://git.openjdk.org/jdk/pull/23340#pullrequestreview-2579313034
PR Comment: https://git.openjdk.org/jdk/pull/23340#issuecomment-2619958603
