On Wed, 29 Jan 2025 23:52:40 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert waitForReferenceProcessing removals, see JDK-8305186
>
> src/java.base/share/classes/java/nio/Bits.java line 146:
>
>> 144: }
>> 145:
>> 146: if (canary == null || canary.isDead()) {
>
> If we're keeping Reference.waitForPendingReferences, why not continue to use
> it, rather than introducing
> the canary as a new, ad hoc, reference processing progress detector?
@kimbarrett Do you have a change coming to allow waitForPendingReferences be
used by WB? I assume this will at least add a comment to the method (or
whatever it changes to) to make it clear that it's for testing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22165#discussion_r1935209408
