On Mon, 3 Feb 2025 09:02:59 GMT, Stephen Colebourne <scolebou...@openjdk.org> wrote:
> My comments refer to the outer parts of the PR. I haven't reviewed the class > file generation part. > > With these changes, please ensure that the same field can be output twice. > Not sure if any tests cover that. > > Thanks for the performance boost. Thanks @jodastephen, the optimization of this PR is to take a shorter path through ClassFile generation, without changing the original behavior. The behavior of outputting the same field multiple times should be the same as before. I will also add tests to cover the current changes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23384#issuecomment-2630982846
